lkml.org 
[lkml]   [2005]   [Apr]   [12]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [patch 1/9] GFP_ZERO fix
    Nick Piggin <nickpiggin@yahoo.com.au> wrote:
    >
    > #define GFP_LEVEL_MASK (__GFP_WAIT|__GFP_HIGH|__GFP_IO|__GFP_FS| \
    > - __GFP_COLD|__GFP_NOWARN|__GFP_REPEAT| \
    > - __GFP_NOFAIL|__GFP_NORETRY|__GFP_NO_GROW|__GFP_COMP)
    > + __GFP_COLD|__GFP_NOWARN|__GFP_REPEAT|__GFP_NOFAIL| \
    > + __GFP_NORETRY|__GFP_NO_GROW|__GFP_COMP|__GFP_ZERO)

    Passing GFP_ZERO into kmem_cache_alloc() is such a bizarre thing to do,
    perhaps a BUG is the correct response.

    I guess it could be argued that the kmem_cache_alloc() callers "knows" that
    the ctor will be zeroing out all the objects, but it would seem cleaner to
    me to pass the "you should use GFP_ZERO" hint into kmem_cache_create()
    rather than kmem_cache_alloc().

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-04-13 04:35    [W:3.508 / U:0.020 seconds]
    ©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site