Messages in this thread | | | Date | Mon, 11 Apr 2005 13:03:18 -0700 | From | Greg KH <> | Subject | Re: [PATCH] kernel 2.6.11.6 - I2C adaptor for ColdFire 5282 CPU |
| |
On Sun, Apr 10, 2005 at 12:47:42PM -0400, Derek Cheung wrote: > Enclosed please find the updated patch that incorporates changes for all > the comments I received.
You did not cc: the sensors mailing list, nor fix all of the coding style issues.
> The volatile declaration in the m528xsim.h is needed because the > declaration refers to the ColdFire 5282 register mapping.
Shouldn't you be calling ioremap, and not directly accessing a specific register location through a pointer? That's how all other arches do this.
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |