Messages in this thread | | | Date | Fri, 1 Apr 2005 14:14:42 +0900 | From | Tejun Heo <> | Subject | Re: [PATCH scsi-misc-2.6 02/13] scsi: don't turn on REQ_SPECIAL on sgtable allocation failure. |
| |
Hello, James.
On Thu, Mar 31, 2005 at 11:53:45AM -0600, James Bottomley wrote: > On Thu, 2005-03-31 at 18:08 +0900, Tejun Heo wrote: > > Don't turn on REQ_SPECIAL on sgtable allocation failure. This > > was the last place where REQ_SPECIAL is turned on for normal > > requests. > > If you do this, you'll leak a command every time the sgtable allocation > fails.
AFAICT, not really. We don't allocate another scsi_cmnd for normal requests if req->special != NULL.
Thanks.
-- tejun
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |