Messages in this thread | | | Date | Wed, 09 Mar 2005 18:03:10 -0600 | From | Steven Pratt <> | Subject | Re: [PATCH 2/2] readahead: improve sequential read detection |
| |
Ram wrote:
>On Wed, 2005-03-02 at 11:08, Oleg Nesterov wrote: > > >..snip... > > > >>@@ -527,7 +527,7 @@ page_cache_readahead(struct address_spac >> } >> >> out: >>- return newsize; >>+ return ra->prev_page + 1; >> >> > >This change introduces one key behavioural change in >page_cache_readahead(). Instead of returning the number-of-pages >successfully read, it now returns the next-page-index which is yet to be >read. Was this essential? > > > and unless filmap.c was changed accordingly this is broken.. need. to look at this more.
Steve
>At least, a comment towards this effect at the top of the function is >worth adding. > >RP > >
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |