Messages in this thread Patch in this message | | | Date | Wed, 09 Mar 2005 12:18:21 -0500 | From | Wen Xiong <> | Subject | Re: [ patch 4/7] drivers/serial/jsm: new serial device driver |
| |
Greg KH wrote:
>On Wed, Mar 09, 2005 at 10:47:22AM -0500, Wen Xiong wrote: > > >>+static ssize_t jsm_driver_debug_show(struct device_driver *ddp, char *buf) >>+{ >>+ return snprintf(buf, PAGE_SIZE, "0x%x\n", jsm_debug); >>+} >>+static DRIVER_ATTR(debug, S_IRUSR, jsm_driver_debug_show, NULL); >> >> > >Should just be a module paramater, right? So you can drop this too... > >This file is getting quite small now :) > >thanks, > >greg k-h > > > If I removed two module paramaters, only two files left: version and state. Removed all of them?
Thanks, wendy
diff -Nuar linux-2.6.11.org/drivers/serial/jsm/jsm_sysfs.c linux-2.6.11.new/drivers/serial/jsm/jsm_sysfs.c --- linux-2.6.11.org/drivers/serial/jsm/jsm_sysfs.c 1969-12-31 18:00:00.000000000 -0600 +++ linux-2.6.11.new/drivers/serial/jsm/jsm_sysfs.c 2005-03-09 11:17:37.055947624 -0600 @@ -0,0 +1,53 @@ +/************************************************************************ + * Copyright 2003 Digi International (www.digi.com) + * + * Copyright (C) 2004 IBM Corporation. All rights reserved. + * + * This program is free software; you can redistribute it and/or modify + * it under the terms of the GNU General Public License as published by + * the Free Software Foundation; either version 2, or (at your option) + * any later version. + * + * This program is distributed in the hope that it will be useful, + * but WITHOUT ANY WARRANTY, EXPRESS OR IMPLIED; without even the + * implied warranty of MERCHANTABILITY or FITNESS FOR A PARTICULAR + * PURPOSE. See the GNU General Public License for more details. + * + * You should have received a copy of the GNU General Public License + * along with this program; if not, write to the Free Software + * Foundation, Inc., 59 * Temple Place - Suite 330, Boston, + * MA 02111-1307, USA. + * + * Contact Information: + * Scott H Kilau <Scott_Kilau@digi.com> + * Wendy Xiong <wendyx@us.ltcfwd.linux.ibm.com> + * + ***********************************************************************/ +#include <linux/device.h> +#include <linux/serial_reg.h> + +#include "jsm_driver.h" + +static ssize_t jsm_driver_version_show(struct device_driver *ddp, char *buf) +{ + return snprintf(buf, PAGE_SIZE, "%s\n", JSM_VERSION); +} +static DRIVER_ATTR(version, S_IRUSR, jsm_driver_version_show, NULL); + +static ssize_t jsm_driver_state_show(struct device_driver *ddp, char *buf) +{ + return snprintf(buf, PAGE_SIZE, "%s\n", jsm_driver_state_text[jsm_driver_state]); +} +static DRIVER_ATTR(state, S_IRUSR, jsm_driver_state_show, NULL); + +void jsm_create_driver_sysfiles(struct device_driver *driverfs) +{ + driver_create_file(driverfs, &driver_attr_version); + driver_create_file(driverfs, &driver_attr_state); +} + +void jsm_remove_driver_sysfiles(struct device_driver *driverfs) +{ + driver_remove_file(driverfs, &driver_attr_version); + driver_remove_file(driverfs, &driver_attr_state); +} | |