Messages in this thread | | | Date | Wed, 9 Mar 2005 08:35:18 -0800 | From | Greg KH <> | Subject | Re: [ patch 4/7] drivers/serial/jsm: new serial device driver |
| |
On Wed, Mar 09, 2005 at 10:47:22AM -0500, Wen Xiong wrote: > +static ssize_t jsm_driver_debug_show(struct device_driver *ddp, char *buf) > +{ > + return snprintf(buf, PAGE_SIZE, "0x%x\n", jsm_debug); > +} > +static DRIVER_ATTR(debug, S_IRUSR, jsm_driver_debug_show, NULL);
Should just be a module paramater, right? So you can drop this too...
This file is getting quite small now :)
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |