lkml.org 
[lkml]   [2005]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH] whitespace cleanups for fs/cifs/file.c
    On 07/03/05 10:26 +0100, Edgar, Bob wrote:
    > I lurk on the list and didn't comment last time but there is one aspect
    > of this patch that I think is "bad" style. The function declaration should
    > not be on the same line with the type. Why? Try to find the file where a
    > function is defined instead of used. If you grep "^funcname" you'll find
    > it quite simply. The same is true in YFE (mine being vi) /^funcname gets
    > me there in one shot.

    Does anybody actually use grep "^funcname"? cscope/ctags is the way.

    >
    > This may not seem an important thing but when you are coming into a
    > project cold and don't know how anything works or where it lives it
    > can be very important. Consider trying to find where some common
    > function from a library is defined in a project with sever 1000 files.

    Again... cscope or ctags will make your life much easier here.

    >
    > I now return you to your regularly scheduled programming.
    >
    > bob
    >
    > -----Original Message-----
    > From:
    > samba-technical-bounces+bob.edgar=commerzbankib.com@lists.samba.org
    > [mailto:samba-technical-bounces+bob.edgar=commerzbankib.com@lists.samba.
    > org]On Behalf Of Jesper Juhl
    > Sent: Freitag, 4. März 2005 20:24
    > To: Steve French
    > Cc: Jörn Engel; Luca Tettamanti; samba-technical; Linux Kernel Mailing
    > List; Domen Puncer
    > Subject: [PATCH] whitespace cleanups for fs/cifs/file.c
    ...
    > -int
    > -cifs_open(struct inode *inode, struct file *file)
    > +int cifs_open(struct inode *inode, struct file *file)
    ...
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:10    [W:0.027 / U:91.204 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site