lkml.org 
[lkml]   [2005]   [Mar]   [7]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    From
    SubjectRe: [PATCH 23/29] FAT: Remove the multiple MSDOS_SB() call
    On Sun, Mar 06, 2005 at 03:56:51AM +0900, OGAWA Hirofumi wrote:
    >
    > Since MSDOS_SB() is inline function, it increases text size at each calls.
    > I don't know whether there is __attribute__ for avoiding this.
    >
    > This removes the multiple call.
    >...

    "inline" in the kernel is (for recent gcc's) mapped to
    __attribute__((always_inline)), and therefore the
    "static inline struct msdos_sb_info *MSDOS_SB" does exactly the opposite
    of what you want.

    You'd have to move this into a .c file to remove the "inline".

    But considering that the whole function is

    static inline struct msdos_sb_info *MSDOS_SB(struct super_block *sb)
    {
    return sb->s_fs_info;
    }

    I'm quite surprised that there's any problem with it.

    cu
    Adrian

    --

    "Is there not promise of rain?" Ling Tan asked suddenly out
    of the darkness. There had been need of rain for many days.
    "Only a promise," Lao Er said.
    Pearl S. Buck - Dragon Seed

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:10    [W:0.036 / U:90.448 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site