lkml.org 
[lkml]   [2005]   [Mar]   [4]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: BIOS overwritten during resume (was: Re: Asus L5D resume on battery power)
Hi!

> > Actually, take a look at Nigel's patch. He simply uses PageNosave
> > instead of PageLocked -- that is cleaner.
>
> Yes. I thought about using PG_nosave in the begining, but there's a
>
> BUG_ON(PageReserved(page) && PageNosave(page));
>
> in swsusp.c:saveable() that I just didn't want to trigger. It seems to me,
> though, that we don't need it any more, do we?

No, we can just kill it. It was "if something unexpected happens, bail
out soon".

> > He also found a few places where reserved page becomes un-reserved,
> > and you probably need to fix those, too.
>
> Yes, I think I'll just port the Nigel's patch to x86-64. BTW, it's striking
> that we found similar solutions independently (I didn't know the Nigel's
> patch before :-)).
>
> Unfortunately, it turns out that the patch does not fix my problem with random
> reboots during resume on battery power, but I really think that we
> need to mark

:-( too bad.

> non-RAM areas with PG_nosave, at least for sanity reasons (eg to be sure that
> we do not break things by dumping stuff to where we should not write to).

I'm not sure if it is not better to save & restore non-RAM areas, but
it probably just does not matter.
Pavel
--
People were complaining that M$ turns users into beta-testers...
...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl!
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:10    [W:0.977 / U:0.008 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site