lkml.org 
[lkml]   [2005]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [RFC] CryptoAPI & Compression
From
Date
Hello Herbert,

> The GNU coding style is completely different from Linux.
Ok, NP.

> Please reformat it when you fix up the overhead calculation.
Sure.

> Good catch. I'll apply this one.
Only one small note: I've spotted this but didn't test. I didn't make
sure this is OK if we haven't ever used the compression and remove the
deflate module. (i.e, in this case we call zlib_[in|de]flateEnd() while
we haven't ever called zlib_[in|de]flate()). Although I believe it must
be OK, we need to try it.

So please, test it or wait while I'll do it.

> The crypto API needs to operate on buffers that's bigger than that so
> we need to have a correct upper bound the maximum expansion.
Well, I'm still not sure. I guess that we call deflate with Z_SYNC_FLUSH
so most data is already in the output buffer and we only need to provide
some room for end markers and the like at the final Z_FINISH call. And I
guess 12 bytes is enough. But again, this is only my guess. I need to
delve into zlib internals to explore this.

So, it seems I can't just port the JFFS2 stuff. I need to explore zlib
more closely. Thus, I need some time. I'll inform you about my results.

> I believe this bit of code originally came from FreeS/WAN and was
> written by Svenning Srensen. Maybe he or Yoshifuji-san can tell
> us why?
If you find some information about the issue, please, let me know.

--
Best Regards,
Artem B. Bityuckiy,
St.-Petersburg, Russia.

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-06 13:31    [W:0.070 / U:19.348 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site