Messages in this thread | | | Date | Thu, 31 Mar 2005 20:41:35 -0600 | From | Tommy Reynolds <> | Subject | Re: connector.c |
| |
Uttered Andrew Morton <akpm@osdl.org>, spake thus:
> > if (uskb) { > > netlink_unicast(dev->nls, uskb, 0, 0); > > } > > Unneeded {}
Speaking strictly as a language lawyer, they are not needed.
However, for maintainability (and best practices) they are essential. They make the scope of the test explicit and ensure that a one-line- change really doesn't affect more lines that needed. Think context diffs here.
Cheers! [unhandled content-type:application/pgp-signature] | |