Messages in this thread |  | | Date | Thu, 31 Mar 2005 15:32:35 +0100 | From | Christoph Hellwig <> | Subject | Re: Fwd: [PATCH] Pageset Localization V2 |
| |
On Wed, Mar 30, 2005 at 06:36:18PM +0530, shobhit dayal wrote: > The goal here is to replace the head of a existing list pointed to by > 'list' with a new head pointed to by 'nlist'. > First there is a memcpy that copies the contents of list to nlist then > this macro is called. > The macro makes sure that if the old head was empty then INIT_LIST_HEAD > the 'nlist', if not then make sure that the nodes before and after the > head now correclty point to nlist instead of list.
Which would be much nicer done using INIT_LIST_HEAD on the new head always and then calling list_replace (of which currently only a _rcu variant exists).
Note to Christoph: Just duplicating the code doesn't make it better ;-)
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
|  |