lkml.org 
[lkml]   [2005]   [Mar]   [31]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: NFS client latencies
    From
    Date
    to den 31.03.2005 Klokka 06:58 (-0500) skreiv Trond Myklebust:
    >
    > @@ -563,11 +566,14 @@ static int
    > nfs_scan_commit(struct inode *inode, struct list_head *dst, unsigned long idx_start, unsigned int npages)
    > {
    > struct nfs_inode *nfsi = NFS_I(inode);
    > - int res;
    > - res = nfs_scan_list(&nfsi->commit, dst, idx_start, npages);
    > - nfsi->ncommit -= res;
    > - if ((nfsi->ncommit == 0) != list_empty(&nfsi->commit))
    > - printk(KERN_ERR "NFS: desynchronized value of nfs_i.ncommit.\n");
    > + int res;
    ^^^^^^^ Should be "int res = 0;"
    > +
    > + if (nfsi->ncommit != 0) {
    > + res = nfs_scan_list(&nfsi->commit, dst, idx_start, npages);
    > + nfsi->ncommit -= res;
    > + if ((nfsi->ncommit == 0) != list_empty(&nfsi->commit))
    > + printk(KERN_ERR "NFS: desynchronized value of nfs_i.ncommit.\n");
    > + }
    > return res;
    > }
    > #endif

    Cheers,
    Trond
    --
    Trond Myklebust <trond.myklebust@fys.uio.no>

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-04-06 13:31    [W:0.119 / U:0.488 seconds]
    ©2003-2014 Jasper Spaans. hosted at Digital Ocean