Messages in this thread | | | Date | Tue, 29 Mar 2005 17:56:13 -0500 | From | Jeff Garzik <> | Subject | Re: [PATCH] fixup newly added jsm driver |
| |
Andrew Morton wrote: > Christoph Hellwig <hch@lst.de> wrote: > >>One more prematurely added drivers.. > > > This driver was first sent out for review a month ago, was upissued twice > and generated over seventy linux-kernel emails including some from Russell > and some from Greg. It was by no means a "premature" addition. > > One could say that it was inadequately reviewed, but how is one to > determine that? If the thing has been under discussion for a month and the > submitter says "I've addressed all comments" then it's going to get merged.
I'd characterize it slightly differently than both of you:
It got a decent review, but from Christoph's list it looks like not all the issues raised during the review got addressed.
FWIW.
Jeff
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |