lkml.org 
[lkml]   [2005]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [RFC] spinlock_t & rwlock_t break_lock member initialization (patch seeking comments included)
On Sun, 27 Mar 2005, Zwane Mwaikambo wrote:

> On Sun, 27 Mar 2005, Jesper Juhl wrote:
>
> > I've now been running kernels (both PREEMPT, SMP, both and without both)
> > with the patch below applied for a few days and I see no ill effects. I'm
> > still interrested in comments about wether or not something like this
> > makes sense and is acceptable ?
>
> The concept seems fine to me, although i think you should be using named
> initialisers instead.
>
I wrote it the way I did to keep it similar to how the other members were
initialized, I wouldn't mind a different approach, but doing it this way
seemed to be what would "fit in" best, and it did the trick for me
(silenced the annoying warnings) and seemed safe.

Thank you for taking the time to comment on this trivial issue.

--
Jesper

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-06 13:31    [W:0.033 / U:4.264 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site