lkml.org 
[lkml]   [2005]   [Mar]   [27]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [2.6 patch] drivers/usb/media/usbvideo.c: fix a check after use
Hi Adrian,

> This patch fixes a check after use found by the Coverity checker.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
>
> --- linux-2.6.12-rc1-mm1-full/drivers/usb/media/usbvideo.c.old 2005-03-23 04:59:11.000000000 +0100
> +++ linux-2.6.12-rc1-mm1-full/drivers/usb/media/usbvideo.c 2005-03-23 04:59:46.000000000 +0100
> @@ -1814,12 +1814,12 @@
> {
> int i, j;
>
> - if (uvd->debug > 1)
> - info("%s($%p)", __FUNCTION__, uvd);
> -
> if ((uvd == NULL) || (!uvd->streaming) || (uvd->dev == NULL))
> return;
>
> + if (uvd->debug > 1)
> + info("%s($%p)", __FUNCTION__, uvd);
> +

Note that you slightly change the debug trace when doing this. For
example, the case where udv != NULL and !udv->streaming would display
the debug line before your patch, and no more after.

Now I don't know whether that change is a problem or not in this
particular case, as I am not the one who would debug this driver if
there were a problem with it, but this is something to pay attention to
in such cases.

Thanks,
--
Jean Delvare
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-06 13:31    [W:0.048 / U:5.672 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site