Messages in this thread | | | Date | Sat, 26 Mar 2005 09:50:11 +0200 | From | Pekka Enberg <> | Subject | Re: [PATCH] no need to check for NULL before calling kfree() - fs/ext2/ |
| |
Hi,
On Fri, 25 Mar 2005 17:29:56 -0500 (EST), linux-os <linux-os@analogic.com> wrote: > Isn't it expensive of CPU time to call kfree() even though the > pointer may have already been freed? I suggest that the check > for a NULL before the call is much less expensive than calling > kfree() and doing the check there. The resulting "double check" > is cheap, compared to the call.
Resource release paths are usually not performance critical. However, if removing the redundant checks introduce a _measurable_ regressions in terms of performance, we can make kfree() inline which will take care of it.
Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |