lkml.org 
[lkml]   [2005]   [Mar]   [26]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: Linux 2.4.30-rc2 - fix for CAN-2005-0794: Potential DOS in load_elf_library
On Sat, Mar 26, 2005 at 01:14:01PM +0100, Andreas Arens wrote:
> Hi Marcelo, Herbert,
>
> I'm just reading the patch so don't know of any hidden side-effects which
> might cure it, but this clearly looks like a possibly deadlocking typo in
> fs/binfmt_elf.c to me:
> >
> >- while (elf_phdata->p_type != PT_LOAD) elf_phdata++;
> >+ while (elf_phdata->p_type != PT_LOAD)
> >+ eppnt++;
>
> Shouldn't this be:
>
> - while (elf_phdata->p_type != PT_LOAD) elf_phdata++;
> + while (eppnt->p_type != PT_LOAD)
> + eppnt++;

Doh.

Yes, it is. I change it accordingly, will release another -rc :(
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-06 13:30    [W:0.049 / U:0.356 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site