Messages in this thread | | | Date | Sat, 26 Mar 2005 12:39:06 -0300 | From | Marcelo Tosatti <> | Subject | Re: Linux 2.4.30-rc2 - fix for CAN-2005-0794: Potential DOS in load_elf_library |
| |
On Sat, Mar 26, 2005 at 01:14:01PM +0100, Andreas Arens wrote: > Hi Marcelo, Herbert, > > I'm just reading the patch so don't know of any hidden side-effects which > might cure it, but this clearly looks like a possibly deadlocking typo in > fs/binfmt_elf.c to me: > > > >- while (elf_phdata->p_type != PT_LOAD) elf_phdata++; > >+ while (elf_phdata->p_type != PT_LOAD) > >+ eppnt++; > > Shouldn't this be: > > - while (elf_phdata->p_type != PT_LOAD) elf_phdata++; > + while (eppnt->p_type != PT_LOAD) > + eppnt++;
Doh.
Yes, it is. I change it accordingly, will release another -rc :( - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |