lkml.org 
[lkml]   [2005]   [Mar]   [25]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    Date
    SubjectRe: [PATCH] Re: Bitrotting serial drivers
    From
    From: Russell King <rmk+lkml@arm.linux.org.uk>
    Date: Thu, 24 Mar 2005 12:17:46 +0000
    > On Thu, Mar 24, 2005 at 07:14:24PM +0900, Hirokazu Takata wrote:
    > > Could you please accept the following patch?
    >
    > Probably, but I'd like to have a reply to my comments below first.
    >
    > > diff -ruNp a/include/asm-m32r/serial.h b/include/asm-m32r/serial.h
    > > --- a/include/asm-m32r/serial.h 2004-12-25 06:35:40.000000000 +0900
    > > +++ b/include/asm-m32r/serial.h 2005-03-24 17:25:05.812651363 +0900
    >
    > Can m32r accept PCMCIA cards? If so, this may mean that 8250.c gets
    > built, which will use this file to determine where it should look for
    > built-in 8250 ports.
    >
    > If this file is used to describe non-8250 compatible ports, you could
    > end up with a nasty mess. Therefore, I recommend that you do not use
    > asm-m32r/serial.h to describe your SIO ports.

    I understand.

    You mean I have to keep 8250.c buildable for PCMCIA serial cards,
    if I make use of both m32r_sio and 8250 compatible drivers at a time, right?

    > Instead, since these definitions are private to your own driver, you
    > may consider moving them into the driver, or a header file closely
    > associated with your driver in drivers/serial.

    I will try to move these definitions into the m32r_sio driver.
    Please just a moment, I have no time to do it now...

    Thank you.

    -- Takata
    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-04-06 13:30    [W:0.023 / U:0.396 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site