Messages in this thread Patch in this message | | | Date | Fri, 25 Mar 2005 19:29:57 +0100 | From | Adrian Bunk <> | Subject | [2.6 patch] drivers/char/ipmi/ipmi_msghandler.c: fix an off by one error |
| |
This patch fixes an off by one error found by the Coverity checker (ipmi_interfaces contains MAX_IPMI_INTERFACES elements).
Signed-off-by: Adrian Bunk <bunk@stusta.de>
--- linux-2.6.12-rc1-mm1-full/drivers/char/ipmi/ipmi_msghandler.c.old 2005-03-23 01:28:29.000000000 +0100 +++ linux-2.6.12-rc1-mm1-full/drivers/char/ipmi/ipmi_msghandler.c 2005-03-23 01:28:50.000000000 +0100 @@ -641,7 +641,7 @@ int ipmi_create_user(unsigned int return -ENOMEM; down_read(&interfaces_sem); - if ((if_num > MAX_IPMI_INTERFACES) || ipmi_interfaces[if_num] == NULL) + if ((if_num >= MAX_IPMI_INTERFACES) || ipmi_interfaces[if_num] == NULL) { rv = -EINVAL; goto out_unlock; - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |