Messages in this thread | | | Date | Wed, 23 Mar 2005 23:25:51 -0800 | From | Greg KH <> | Subject | Re: [PATCH 0/5] I8K driver facelift |
| |
On Thu, Mar 17, 2005 at 01:40:48AM -0500, Dmitry Torokhov wrote: > On Wednesday 16 March 2005 16:38, Frank Sorenson wrote: > > Okay, I replaced the sysfs_ops with ops of my own, and now all the show > > and store functions also accept the name of the attribute as a parameter. > > This lets the functions know what attribute is being accessed, and allows > > us to create attributes that share show and store functions, so things > > don't need to be defined at compile time (I feel slightly evil!). > > Hrm, can we be a little more explicit and not poke in the sysfs guts right > in the driver? What do you think about the patch below athat implements > "attribute arrays"? And I am attaching cumulative i8k patch using these > arrays so they can be tested. > > I am CC-ing Greg to see what he thinks about it.
Hm, I think it's proably of limited use, right? What other code would want this (the i2c sensor code doesn't, as it's naming scheme is different.)
What drivers _do_ want is a way to create attributes on the fly easily, and be able to have a "private" pointer to determine easier what file was opened (to allow a single file handler, instead of the current one-per-attribute type).
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |