lkml.org 
[lkml]   [2005]   [Mar]   [24]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
From
SubjectRe: [PATCH] usbnet.c, buf.overrun crash-bugfix, Kernel 2.6.12-rc1
Date
On Thursday 24 March 2005 10:13 am, Jakemuksen spammiosote wrote:
> On Thu, 24 Mar 2005, David Brownell wrote:
> > On Thursday 24 March 2005 8:05 am, Jakemuksen spammiosote wrote:
>
> >> + if (unlikely((skb->tail + urb->actual_length) > skb->end)) {
> >
> > This logic looks wrong. If that ever happens, surely the problem is
> > that the rx_submit() code submitted an urb with transfer_size that
> > mismatched the SKB. The host controller isn't allowed to overrun the
>
> Sounds reasonable. So, I'll go thru the HCD code

Better yet, start with the code supporting that device you're
under NDA for.


> instead if the
> responsibility is there. Am i the first one to run into such crash
> situation? If so, perhaps it's not ever worthy to fix in mainstream
> kernel, as the device causes the crash under very specific -
> 'abusing' one might say, situation only.

You're the first one to report such a problem.

- Dave
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-06 13:30    [W:0.897 / U:0.844 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site