lkml.org 
[lkml]   [2005]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
Patch in this message
/
From
SubjectRe: memory leak in net/sched/ipt.c?
Date
Yichen Xie <yxie@cs.stanford.edu> wrote:
> Is the memory block allocated on line 315 leaked every time tcp_ipt_dump
> is called?

It seems to be. This patch should free it.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>

BTW, please report networking bugs to netdev@oss.sgi.com.

Thanks,
--
Visit Openswan at http://www.openswan.org/
Email: Herbert Xu ~{PmV>HI~} <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
--
===== net/sched/ipt.c 1.14 vs edited =====
--- 1.14/net/sched/ipt.c 2005-02-07 16:39:40 +11:00
+++ edited/net/sched/ipt.c 2005-03-23 22:28:13 +11:00
@@ -284,10 +284,12 @@
tm.lastuse = jiffies_to_clock_t(jiffies - p->tm.lastuse);
tm.expires = jiffies_to_clock_t(p->tm.expires);
RTA_PUT(skb, TCA_IPT_TM, sizeof (tm), &tm);
+ kfree(t);
return skb->len;

rtattr_failure:
skb_trim(skb, b - skb->data);
+ kfree(t);
return -1;
}

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
\
 
 \ /
  Last update: 2005-04-06 13:30    [W:0.079 / U:0.964 seconds]
©2003-2017 Jasper Spaans. hosted at Digital OceanAdvertise on this site