lkml.org 
[lkml]   [2005]   [Mar]   [23]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: memory leak in net/sched/ipt.c?
From
Date
On Wed, 2005-03-23 at 08:23, Thomas Graf wrote:

>
> kfree simply does nothing if it is given a null pointer so that
> goto rtattr_failure for t == NULL is handled just fine without
> a check. I will never get used to this behaviour and policy as
> well though, it somewhat makes code less readable.
>

I cant get used to it either; actually i dont think i would be able
to stop my fingers ;->

> > didnt understand the janitor part.
>
> It will probably be removed again by one of the regular 'remove
> unnecessary pre kfree checks' patchsets.
>

Yes, already Jan Engelhardt <jengelh@linux01.gwdg.de> has made that
point - although he did not post to netdev!! ;->

So ignore my comment Herbert

cheers,
jamal

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-04-06 13:30    [W:0.048 / U:0.220 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site