Messages in this thread | | | Date | Wed, 23 Mar 2005 14:34:30 +1100 | From | David Gibson <> | Subject | Re: [PATCH 2.6.12-rc1-mm1 3/3] perfctr: 64-bit values in register descriptors |
| |
On Wed, Mar 23, 2005 at 04:00:03AM +0100, Mikael Pettersson wrote: > - <linux/perfctr.h>: Change value fields in register descriptors > to 64 bits. This will be needed for ppc64, and ppc32 user-space > on ppc64 kernels, and may eventually also be needed on x86. > We could have different descriptor types for 32 and 64-bit > registers, but that just complicates things for no real benefit. > > Signed-off-by: Mikael Pettersson <mikpe@csd.uu.se>
Erm.. won't this stop i386 binaries working on an x86_64 kernel, since kernel and user will have different ideas of the alignment...?
> include/linux/perfctr.h | 4 ++-- > 1 files changed, 2 insertions(+), 2 deletions(-) > > diff -rupN linux-2.6.12-rc1-mm1/include/linux/perfctr.h linux-2.6.12-rc1-mm1.perfctr-update-common/include/linux/perfctr.h > +++ linux-2.6.12-rc1-mm1.perfctr-update-common/include/linux/perfctr.h 2005-03-23 02:19:45.000000000 +0100 > @@ -27,10 +27,10 @@ struct vperfctr_control { > #define VPERFCTR_CONTROL_RESUME 0x03 > #define VPERFCTR_CONTROL_CLEAR 0x04 > > -/* common description of an arch-specific 32-bit control register */ > +/* common description of an arch-specific control register */ > struct perfctr_cpu_reg { > __u32 nr; > - __u32 value; > + __u64 value; > }; > > /* state and control domain numbers
-- David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/people/dgibson - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |