Messages in this thread | | | Date | Mon, 21 Mar 2005 00:12:32 +0100 | From | Adrian Bunk <> | Subject | Re: [2.6 patch] i386/x86_64 mpparse.c: kill maxcpus |
| |
On Sun, Mar 20, 2005 at 05:42:34PM -0500, Dave Jones wrote: > On Sun, Mar 20, 2005 at 08:25:49PM +0100, Adrian Bunk wrote: > > Do we really need a global variable that does only hold the value of > > NR_CPUS? > > Yes. > > NR_CPUS = compile time > maxcpus = boot command line at runtime.
If this is how is was expected to work - it isn't exactly what is currently implemented.
The function maxcpus in init/main.c sets a static variable max_cpus - not the global variable maxcpus in the mpparse.c files.
How should it be?
Should max_cpus in init/main.c become global and replace the maxcpus from the mpparse.c files?
> Dave
cu Adrian
--
"Is there not promise of rain?" Ling Tan asked suddenly out of the darkness. There had been need of rain for many days. "Only a promise," Lao Er said. Pearl S. Buck - Dragon Seed
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |