Messages in this thread | | | Date | Thu, 17 Mar 2005 15:45:22 +0100 | From | Stelian Pop <> | Subject | BKCVS broken ? |
| |
The current bkcvs export is broken, several recent changesets are missing from it.
This occurs at least in the mm/ directory, but I haven't verified if other directories are not affected. I detected this problem because the head of bkcvs doesn't compile anymore and shows errors in mm/* missing symbols.
One example:
Take this changeset from Changeset,v: ------------------------------------------------------------- 1.27702 log @[PATCH] orphaned pagecache memleak fix
Chris found that with data journaling a reiserfs pagecache may be truncate while still pinned. The truncation removes the page->mapping, but the page is still listed in the VM queues because it still has buffers. Then during the journaling process, a buffer is marked dirty and that sets the PG_dirty bitflag as well (in mark_buffer_dirty). After that the page is leaked because it's both dirty and without a mapping.
So we must allow pages without mapping and dirty to reach the PagePrivate check. The page->mapping will be checked again right after the PagePrivate check.
Signed-off-by: Andrea Arcangeli <andrea@@suse.de> Signed-off-by: Andrew Morton <akpm@@osdl.org> Signed-off-by: Linus Torvalds <torvalds@@osdl.org>
BKrev: 4234d7beMW4wcFI6ltxdMMhApwDmuA -------------------------------------------------------------
Looking at http://linux.bkbits.net:8080/linux-2.6/gnupatch@4234d7beMW4wcFI6ltxdMMhApwDmuA shows this changeset should contain a delta for mm/vmscan.c
However, mm/vmscan.c,v contains: ------------------------------------------------------------- head 1.238; access; symbols; locks; strict; comment @ * @; expand @o@;
1.238 date 2005.03.10.17.06.39; author pj; state Exp; branches; next 1.237; .... 1.238 log @cpusets - big numa cpu and memory placement
(Logical change 1.27465) @ -------------------------------------------------------------
The 'Logical change 1.27702' is missing from the file...
Stelian. -- Stelian Pop <stelian.pop@fr.alcove.com> Alcove - http://www.alcove.com - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |