lkml.org 
[lkml]   [2005]   [Mar]   [15]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    From
    SubjectRe: [PATCH] PPC64 iSeries: cleanup viopath
    Date
    On Mar 14, 2005, at 9:34 PM, Stephen Rothwell wrote:
    >
    > Since you brought this file to my attention, I figured I might as well
    > do
    > some simple cleanups. This patch does:
    > - single bit int bitfields are a bit suspect and Anndrew pointed
    > out recently that they are probably slower to access than ints

    > --- linus/arch/ppc64/kernel/viopath.c 2005-03-13 04:07:42.000000000
    > +1100
    > +++ linus-cleanup.1/arch/ppc64/kernel/viopath.c 2005-03-15
    > 14:02:48.000000000 +1100
    > @@ -56,8 +57,8 @@
    > * But this allows for other support in the future.
    > */
    > static struct viopathStatus {
    > - int isOpen:1; /* Did we open the path? */
    > - int isActive:1; /* Do we have a mon msg outstanding */
    > + int isOpen; /* Did we open the path? */
    > + int isActive; /* Do we have a mon msg outstanding */
    > int users[VIO_MAX_SUBTYPES];
    > HvLpInstanceId mSourceInst;
    > HvLpInstanceId mTargetInst;

    Why not use a byte instead of a full int (reordering the members for
    alignment)?

    --
    Hollis Blanchard
    IBM Linux Technology Center

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:11    [W:0.023 / U:0.028 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site