Messages in this thread | | | Date | Mon, 14 Mar 2005 14:19:17 -0800 | From | "Randy.Dunlap" <> | Subject | Re: [patch] w6692 eliminate bad section references |
| |
maximilian attems wrote: > Fix w6692 section references: > convert __initdata to __devinitdata. > > Error: ./drivers/isdn/hisax/w6692.o .text refers to 0000002f R_386_32 > .init.data > > Signed-off-by: maximilian attems <janitor@sternwelten.at> > > > diff -pruN -X dontdiff linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c > linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c > --- linux-2.6.11-bk8/drivers/isdn/hisax/w6692.c 2005-03-02 08:38:25.000000000 +0100 > +++ linux-2.6.11-bk8-max/drivers/isdn/hisax/w6692.c 2005-03-13 23:36:34.000000000 +0100 > @@ -45,7 +45,7 @@ const char *w6692_revision = "$Revision: > > #define DBUSY_TIMER_VALUE 80 > > -static char *W6692Ver[] __initdata = > +static char *W6692Ver[] __devinitdata = > {"W6692 V00", "W6692 V01", "W6692 V10", > "W6692 V11"}; >
I think the correct fix is to make W6692Version() be __init ... What do you think of that?
-- ~Randy - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |