Messages in this thread | | | From | Blaisorblade <> | Subject | Re: [uml-devel] Re: [PATCH 4/9] UML - Export gcov symbol based on gcc version | Date | Fri, 11 Mar 2005 18:01:29 +0100 |
| |
On Thursday 10 March 2005 23:53, Adrian Bunk wrote: > On Wed, Mar 09, 2005 at 09:16:02PM -0500, Jeff Dike wrote: > > The init function called by gcc when gcov is enabled is __gcov_init or > > __bb_init_func, depending on the gcc version. Anton is using 3.3.4 and > > seeing __gcov_init. I'm using 3.3.2 and seeing __bb_init_func, so we > > need to close that gap a bit. > > > > Signed-off-by: Jeff Dike <jdike@addtoit.com> > > > > Index: linux-2.6.11/arch/um/kernel/gmon_syms.c > > =================================================================== > > --- linux-2.6.11.orig/arch/um/kernel/gmon_syms.c 2005-03-07 > > 10:53:03.000000000 -0500 +++ > > linux-2.6.11/arch/um/kernel/gmon_syms.c 2005-03-07 16:29:37.000000000 > > -0500 @@ -5,8 +5,14 @@ > > > > #include "linux/module.h" > > > > +#if __GNUC__ > 3 || (__GNUC__ == 3 && __GNUC_MINOR__ > 3) || \ > > + (__GNUC__ == 3 && __GNUC_MINOR__ == 3 && __GNUC_PATCHLEVEL__ >= 4) > >... > > This patch is still wrong. > > It seems my comment on this [1] was lost: > > <-- snip --> > > This line has to be something like > > ( (__GNUC__ == 3 && __GNUC_MINOR__ == 3 && __GNUC_PATCHLEVEL__ >= 4) && \ > HEAVILY_PATCHED_SUSE_GCC ) > > I hope SuSE has added some #define to distinguish what they call > "gcc 3.3.4" from GNU gcc 3.3.4 "You hope" does not mean "it exists". Secondly, the patch is wrong anyway, as I said elsewhere. -- Paolo Giarrusso, aka Blaisorblade Linux registered user n. 292729 http://www.user-mode-linux.org/~blaisorblade
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |