lkml.org 
[lkml]   [2005]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
Date
From
SubjectRe: [ patch 3/5] drivers/serial/jsm: new serial device driver
Arjan van de Ven wrote:

>On Fri, 2005-03-11 at 10:38 -0500, Wen Xiong wrote:
>
>
>
>>+static void neo_set_cts_flow_control(struct jsm_channel *ch)
>>+{
>>+ u8 ier = readb(&ch->ch_neo_uart->ier);
>>+ u8 efr = readb(&ch->ch_neo_uart->efr);
>>+
>>
>>
>...
>
>
>>+
>>+ writeb(ier, &ch->ch_neo_uart->ier);
>>+}
>>
>>
>
>
>Hi,
>
>have you ever audited this driver for PCI posting errors? On very first
>sight it looks like the driver doesn't do this correctly but it might
>just be very subtle...
>
>
>
>
Jeff pointed out several PCI posting errors last time. Before we used
udelay and now we changed to readb/readl instead of udelay this time.
But we only used PCI posting when we think maybe delay there.
So we have to do PCI posting on every writeb? Do you have some rules for
doing PCI posting while writeb? depends on what kind of registers?

Thanks,
wendy

-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:11    [W:0.051 / U:0.192 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site