lkml.org 
[lkml]   [2005]   [Mar]   [11]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
    /
    SubjectRe: [ patch 3/5] drivers/serial/jsm: new serial device driver
    From
    Date
    On Fri, 2005-03-11 at 10:38 -0500, Wen Xiong wrote:

    > +static void neo_set_cts_flow_control(struct jsm_channel *ch)
    > +{
    > + u8 ier = readb(&ch->ch_neo_uart->ier);
    > + u8 efr = readb(&ch->ch_neo_uart->efr);
    > +
    ...
    > +
    > + writeb(ier, &ch->ch_neo_uart->ier);
    > +}


    Hi,

    have you ever audited this driver for PCI posting errors? On very first
    sight it looks like the driver doesn't do this correctly but it might
    just be very subtle...

    -
    To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
    the body of a message to majordomo@vger.kernel.org
    More majordomo info at http://vger.kernel.org/majordomo-info.html
    Please read the FAQ at http://www.tux.org/lkml/

    \
     
     \ /
      Last update: 2005-03-22 14:11    [W:0.022 / U:32.900 seconds]
    ©2003-2016 Jasper Spaans. hosted at Digital OceanAdvertise on this site