Messages in this thread | | | From | David Howells <> | Subject | Re: [PATCH] keys: Discard key spinlock and use RCU for key payload [try #3] | Date | Thu, 10 Mar 2005 12:57:48 +0000 |
| |
David Howells <dhowells@redhat.com> wrote:
> > What's with the preempt_enable()/disable() added to __key_link()? It's not > > obvious what is being protected from what, and why. > > Ummm... Yes... They're probably not necessary. A wmb() may be required after > the klist->nkeys++ to commit to memory the fact there's now an extra key link > available, but I'm not sure that it's necessary.
I should perhaps be using smp_wmb() not wmb().
David - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |