Messages in this thread | | | From | Dmitry Torokhov <> | Subject | Re: Touchpad problems with 2.6.11-rc2 | Date | Thu, 3 Feb 2005 02:16:05 -0500 |
| |
On Wednesday 02 February 2005 17:27, Peter Osterlund wrote: > On Wed, 2 Feb 2005, Dmitry Torokhov wrote: > > > On Wed, 02 Feb 2005 13:52:03 -0800 (PST), Peter Osterlund > > <petero2@telia.com> wrote: > > > > > > if (mousedev->touch) { > > > + size = dev->absmax[ABS_X] - dev->absmin[ABS_X]; > > > + if (size == 0) size = xres; > > > > Sorry, missed this piece first time around. Since we don't want to > > rely on screen size anymore I think we should set size = 256 * > > FRACTION_DENOM / 2 if device limits are not set up to just report raw > > coords. What do you think? > > I think that this case can't happen until we add support for some other > touchpad that doesn't set the absmin/absmax variables. Both alps and > synaptics currently set them. > > However, the fallback value should definitely not depend on > FRACTION_DENOM, since this constant doesn't affect the mouse speed at all.
Oh, yes, we divide by FRACTION_DENOM later. So having size = 256 * 2 should undo all scaling and report coordinates one for one which I think is a reasonable solution if device did not set it's size.
-- Dmitry - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |