lkml.org 
[lkml]   [2005]   [Feb]   [3]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: RFC: [PATCH-2.6] Add helper function to lock multiple page cache pages - loop device
From
Date
>I did a patch which switched loop to use the file_operations.read/write
>about a year ago. Forget what happened to it. It always seemed the
right
>thing to do..

This is unquestionably the right thing to do (at least compared to what we
have now). The loop device driver has no business assuming that the
underlying filesystem uses the generic routines. I always assumed it was
a simple design error that it did. (Such errors are easy to make because
prepare_write and commit_write are declared as address space operations,
when they're really private to the buffer cache and generic writer).

--
Bryan Henderson IBM Almaden Research Center
San Jose CA Filesystems
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:10    [W:0.093 / U:0.212 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site