Messages in this thread | | | Date | Thu, 3 Feb 2005 07:46:45 +0100 | From | Vojtech Pavlik <> | Subject | Re: Touchpad problems with 2.6.11-rc2 |
| |
On Wed, Feb 02, 2005 at 11:58:05PM +0100, Peter Osterlund wrote:
> In practice I don't think it will make any significant difference. What > the code should do depends on what you want to happen if you move the > mouse pointer 1/2 pixel with one finger stroke, then move it another 1/2 > pixel with a second stroke. The patch I posted will move the pointer one > pixel in this case and your code will move it 0 pixels. (The X driver does > not reset the fractions, but that doesn't of course mean that it's the > only right thing to do.) > > > Also, I think the extra unary minus is uncoth. > > The code was written like that to emphasize the fact that X and Y use the > same formula, with the only difference that the kernel Y axis is mirrored > compared to the touchpad Y axis. > > It didn't make any difference for the generated assembly code though, > using gcc 3.4.2 from Fedora Core 3. > > > + enum { FRACTION_DENOM = 100 }; > > The enum is much nicer than my #define.
OK. I like this patch, too. Can you guys send me a final version incorporating the changes of you both for inclusion in the input tree?
-- Vojtech Pavlik SuSE Labs, SuSE CR - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |