Messages in this thread | | | Date | Thu, 3 Feb 2005 15:20:57 +0100 | From | Pavel Machek <> | Subject | Re: cpufreq problem wrt suspend/resume on Athlon64 |
| |
Hi!
> > > > > On Thu, Feb 03, 2005 at 11:41:26AM +0100, Pavel Machek wrote: > > > > > > Okay, you are right, restoring it unconditionaly would be bad > > > > > > idea. Still it would be nice to tell cpufreq governor "please change > > > > > > the frequency ASAP" so it does not run at 800MHz for half an hour > > > > > > compiling kernels on AC power. > > > > > > > > > > It already does that... or at least it should. in cpufreq_resume() there is > > > > > a call to schedule_work(&cpu_policy->update); which will cause a call > > > > > cpufreq_update_policy() in due course. And cpufreq_update_policy() calls the > > > > > governor, and it is supposed to adjust the frequency to the user's wish > > > > > then. > > > > > > > > Ok, so Rafael's suspend() routine seems like good fix... > > > > > > No. I don't see a reason why my desktop P4 should drop to 12.5 frequency > > > (p4-clockmod) if I ask it to suspend to mem. > > > > So, would it be acceptable to check in _suspend() if the state is S4 > > and drop the frequency in that case or do nothing otherwise? > > No. The point is that this is _very_ system-specific. Some systems resume > always at full speed, some always at low speed; for S4 the behaviour may be > completely unpredictable. And in fact I wouldn't want my desktop P4 drop th > 12.5 % frequency if I ask it to suspend to disk, too. "Ignoring" the warning > seems to be the best thing to me. The good thing is, after all, that cpufreq > detected this situation and tries to correct for it.
You may not run k8 notebook on max frequency on battery. Your system will crash; and you might even damage battery. Pavel -- People were complaining that M$ turns users into beta-testers... ...jr ghea gurz vagb qrirybcref, naq gurl frrz gb yvxr vg gung jnl! - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |