Messages in this thread Patch in this message | | | Date | Wed, 2 Feb 2005 14:19:14 -0600 | From | Matt Domsch <> | Subject | Re: [PATCH] Prevent NMI oopser |
| |
On Wed, Feb 02, 2005 at 10:32:28PM +0300, Vasily Averin wrote: > >As a hack, one could #define inline /*nothing*/ in megaraid2.h to > >avoid this, but it would be nice if the functions could all get > >reordered such that inlining works properly, and the need for function > >declarations in megaraid2.h would disappear completely. > > > Could you fix it by additional patch? Or you going to prepare a new one?
Here's the hack patch (will apply after yours).
Signed-off-by: Matt Domsch <Matt_Domsch@dell.com>
-- Matt Domsch Software Architect Dell Linux Solutions linux.dell.com & www.dell.com/linux Linux on Dell mailing lists @ http://lists.us.dell.com
===== drivers/scsi/megaraid2.h 1.6 vs edited ===== --- 1.6/drivers/scsi/megaraid2.h 2005-02-02 13:48:22 -06:00 +++ edited/drivers/scsi/megaraid2.h 2005-02-02 13:55:42 -06:00 @@ -5,6 +5,18 @@ #include <linux/spinlock.h> +/* This is an ugly hack, but gets around the fact that earlier + * versions of gcc ignores the inline specification when + * the function definition comes after function use (thereby + * not inlining the code), and newer gcc fails to compile the + * code. This should be removed once the functions are properly + * ordered in megaraid2.c, and the function declarations removed + * in megaraid2.h. + */ +#undef inline +#define inline /*nothing*/ + + #define MEGARAID_VERSION \ "v2.10.8.2 (Release Date: Mon Jul 26 12:15:51 EDT 2004)\n" - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |