lkml.org 
[lkml]   [2005]   [Feb]   [19]   [last100]   RSS Feed
Views: [wrap][no wrap]   [headers]  [forward] 
 
Messages in this thread
/
SubjectRe: [2.6 patch] drivers/net/smc-mca.c: cleanups
From
Date
On Sat, 2005-02-19 at 03:41 -0500, Jeff Garzik wrote:
> Adrian Bunk wrote:
> > This patch contains the following cleanups:
> > - make a needlessly global function static
> > - make three needlessly global structs static
> >
> > Since after moving the now-static stucts to smc-mca.c the file smc-mca.h
> > was empty except for two #define's, I've also killed the rest of
> > smc-mca.h .
>
> It looks like the structs should be 'static const', not just 'static'.
>
> This comment is applicable to similar changes, also. Use 'const'
> whenever possible.

does that even have meaning in C? In C++ it does, but afaik in C it
doesn't.


-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/

\
 
 \ /
  Last update: 2005-03-22 14:10    [W:0.128 / U:0.024 seconds]
©2003-2020 Jasper Spaans|hosted at Digital Ocean and TransIP|Read the blog|Advertise on this site