Messages in this thread | | | Date | Fri, 18 Feb 2005 10:02:20 +0800 | From | Bernard Blackham <> | Subject | Re: Swsusp, resume and kernel versions |
| |
On Thu, Feb 17, 2005 at 08:56:52PM +0100, Pavel Machek wrote: > > > Just remember you're doing the mkswap if you decide to rearrange your > > > partitions at all, or code a script smart enough to grep your swap > > > partitions out of your fstab. > > > > It could be a workaround. Still it will cause loss of unsaved work if > > I happen to load wrong kernel. Given that the code checking for swsusp > > image can be marked __init I don't understand the reasons gainst doing > > it. > > How do you know which partitions to check? swsusp gets it from resume= parameter, > but if you do not have it compiled, you probably have wrong cmdline, too.
In many cases, you might have added the resume= line to every kernel that's booted (eg, LILO's global append= parameter, or Debian GRUB's magic kopts gear). Alternately (or additionally), you could examine the signature when sys_swapon is called on a swap partition (though the code couldn't be __init then).
These together I want to claim would catch many of these cases, and any effort to avoid severe filesystem corruption is a good thing.
Bernard.
-- Bernard Blackham <bernard at blackham dot com dot au> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |