Messages in this thread | | | Date | Fri, 11 Feb 2005 14:02:19 +0200 | From | Pekka Enberg <> | Subject | Re: [PATCH, new ACPI driver] new sony_acpi driver |
| |
On Fri, 11 Feb 2005 12:36:37 +0100, Stelian Pop <stelian@popies.net> wrote: > +static int __init sony_acpi_add(struct acpi_device *device) > +{ > + acpi_status status = AE_OK; > + struct sony_snc *snc = NULL; > + int result; > + > + snc = kmalloc(sizeof(struct sony_snc), GFP_KERNEL); > + if (!snc) > + return -ENOMEM; > + memset(snc, 0, sizeof(struct sony_snc));
Nitpick: use kcalloc() instead of kmalloc() and memset().
Pekka - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |