Messages in this thread | | | Date | 10 Feb 2005 10:09:03 +0100 | Date | Thu, 10 Feb 2005 10:09:03 +0100 | From | Andi Kleen <> | Subject | Re: [PATCH] relayfs redux, part 4 |
| |
> > Please consider inlining alloc_page_array() and populate_page_array() > into relay_alloc_rchan_buf() as they're only used once. You'd get rid > of passing page_count as a pointer this way. If inlining is > unacceptable, please at least move the n_pages calculation to > relay_alloc_rchan_buf() to make the API more sane.
Modern gcc (3.3-hammer with unit-at-a-time or 3.4) will do that anyways on its own.
-Andi
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |