Messages in this thread | | | Date | Thu, 10 Feb 2005 15:07:47 -0600 | From | Patrick Gefre <> | Subject | Re: [PATCH] Altix : ioc4 serial driver support |
| |
I updated again with more __iomem tags.
ftp://oss.sgi.com/projects/sn2/sn2-update/033-ioc4-support
Signed-off-by: Patrick Gefre <pfg@sgi.com>
Christoph Hellwig wrote: > On Thu, Feb 10, 2005 at 11:09:43AM -0800, Jesse Barnes wrote: > >>On Tuesday, February 8, 2005 8:52 am, Patrick Gefre wrote: >> >>>I've update the patch with changes from the comments below. >>> >>>ftp://oss.sgi.com/projects/sn2/sn2-update/033-ioc4-support >>> >>>Christoph Hellwig wrote: >>> >>>>On Mon, Feb 07, 2005 at 09:58:33AM -0600, Patrick Gefre wrote: >>>> >>>>>Latest version with review mods: >>>>>ftp://oss.sgi.com/projects/sn2/sn2-update/033-ioc4-support >>>> >>>> - still not __iomem annotations. >>> >>>I *think* I have this right ?? >> >>Here's the output from 'make C=1' with your driver patched in (you if you want >>to run it yourself, just copy tomahawk.engr:~jbarnes/bin/sparse to somewhere >>in your path and run 'make C=1'). I think most of these warning would be >>fixed up if the structure fields referring to registers were declared as >>__iomem, but I haven't looked carefully. > > > Actually the pointers to the struct need to be declared __iomem.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |