Messages in this thread | | | Subject | Re: [ide-dev 3/5] generic Power Management for IDE devices | From | Benjamin Herrenschmidt <> | Date | Wed, 02 Feb 2005 10:24:48 +1100 |
| |
On Wed, 2005-02-02 at 00:03 +0100, Bartlomiej Zolnierkiewicz wrote: > On Sat, 22 Jan 2005 19:41:24 +0100, Pavel Machek <pavel@suse.cz> wrote: > > Hi! > > > > > Move PM code from ide-cd.c and ide-disk.c to IDE core so: > > > * PM is supported for other ATAPI devices (floppy, tape) > > > * PM is supported even if specific driver is not loaded > > > > Why do you need to have state-machine? During suspend we are running > > single-threaded, it should be okay to just do the calls directly. > > Pavel > > If we are running single-threaded I also see no reason for state-machine. > Ben? > > Pavel, I assume that changes contained in the patch are OK with you?
We aren't always running single threaded. On PPC we are definitely not :)
Also, we need the request to go down the queue for proper synchronisation. It's all been discussed at lenght a while ago, this is the best way to do it. Also, wakeup can be asynchronous this way.
Ben.
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |