Messages in this thread Patch in this message | | | Date | Fri, 09 Dec 2005 19:04:15 +0100 | From | Arnd Bergmann <> | Subject | [PATCH 1/8] spufs: fix module refcount race |
| |
One of the two users of spufs_calls.owner still has a race when calling try_module_get while the module is removed. This makes it use the correct instance of owner.
Noticed by Milton Miller.
Signed-off-by: Arnd Bergmann <arndb@de.ibm.com> Index: linux-2.6.15-rc/arch/powerpc/platforms/cell/spu_syscalls.c =================================================================== --- linux-2.6.15-rc.orig/arch/powerpc/platforms/cell/spu_syscalls.c +++ linux-2.6.15-rc/arch/powerpc/platforms/cell/spu_syscalls.c @@ -40,7 +40,7 @@ asmlinkage long sys_spu_create(const cha struct module *owner = spufs_calls.owner; ret = -ENOSYS; - if (owner && try_module_get(spufs_calls.owner)) { + if (owner && try_module_get(owner)) { ret = spufs_calls.create_thread(name, flags, mode); module_put(owner); } --
- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |