Messages in this thread | | | Date | Thu, 8 Dec 2005 06:26:32 +0100 | From | Andi Kleen <> | Subject | Re: for_each_online_cpu broken ? |
| |
On Thu, Dec 08, 2005 at 12:07:39AM -0500, Dave Jones wrote: > Whilst debugging a memory leak, I hit sysrq meminfo, > and got hot/cold info for CONFIG_NR_CPUS rather than 4 cpus > I fixed a bug recently in mm/page_alloc.c to change this from > a for_each_cpu to a for_each_online_cpu and I'm pretty certain > I tested that it worked, but for reasons unknown, it's now > misbehaving again. > > I've only tried reproducing this on x86-64 so far.
If the online map is wrong all kinds of things would go wrong.
Most likely your kernel doesn't have the fix.
The possible map is fixed kind of BTW in 2.6.15rc*. It was a side effect of CPU hotplug, which now uses a better algorithm to guess the number of possible CPUs. In 2.6.15 you will just get half the number of available CPUs in addition by default
-Andi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |