Messages in this thread | | | Date | Thu, 8 Dec 2005 21:09:14 +0200 | From | "Michael S. Tsirkin" <> | Subject | set_page_dirty vs set_page_dirty_lock |
| |
Hi! The comment at set_page_dirty_lock says:
/* * set_page_dirty() is racy if the caller has no reference against * page->mapping->host, and if the page is unlocked. This is because another * CPU could truncate the page off the mapping and then free the mapping. * * Usually, the page _is_ locked, or the caller is a user-space process which * holds a reference on the inode by having an open file. * * In other cases, the page should be locked before running set_page_dirty(). */
Still, I wander whether it might be OK to use set_page_dirty in another case - if I previously got a reference to the page with get_user_pages? The page wouldnt be written back in this case, would it? What if I'm in the middle of a system call?
Thanks,
-- MST - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |