Messages in this thread | | | Date | Thu, 8 Dec 2005 11:29:44 -0500 (EST) | From | James Morris <> | Subject | Re: [PATCH] Fix listxattr() for generic security attributes |
| |
On Thu, 8 Dec 2005, Daniel Drake wrote:
> Commit f549d6c18c0e8e6cf1bf0e7a47acc1daf7e2cec1 introduced a generic fallback > for security xattrs, but appears to include a subtle bug. > > Gentoo users with kernels with selinux compiled in, and coreutils compiled > with acl support, noticed that they could not copy files on tmpfs using 'cp'. > > cp (compiled with acl support) copies the file, lists the extended attributes > on the old file, copies them all to the new file, and then exits. However the > listxattr() calls were failing with this odd behaviour: > > llistxattr("a.out", (nil), 0) = 17 > llistxattr("a.out", 0x7fffff8c6cb0, 17) = -1 ERANGE (Numerical result out of > range) > > I believe this is a simple problem in the logic used to check the buffer > sizes; if the user sends a buffer the exact size of the data, then its ok :) > > This patch solves the problem. Please apply for 2.6.15. > More info can be found at http://bugs.gentoo.org/113138 > > Signed-off-by: Daniel Drake <dsd@gentoo.org>
Acked-by: James Morris <jmorris@namei.org>
-- James Morris <jmorris@namei.org> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |