Messages in this thread Patch in this message | | | Date | Wed, 7 Dec 2005 11:58:11 -0500 | From | Dave Jones <> | Subject | Re: Missing break in timedia serial setup. |
| |
On Wed, Dec 07, 2005 at 09:34:31AM +0000, Russell King wrote: > On Tue, Dec 06, 2005 at 08:05:26PM -0500, Dave Jones wrote: > > Spotted during code review by a Fedora user. > > https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=174967 > > Makes no difference. > > switch (idx) { > case 3: > bar = 1; > case 4: /* BAR 2 */ > case 5: /* BAR 3 */ > case 6: /* BAR 4 */ > case 7: /* BAR 5 */ > bar = idx - 2; > > If idx is 3, idx - 2 is 1. So the bar = 1 is actually redundant in > case 3.
Duh, yes of course. Here's a patch to remove the redundant assignment, but as it's harmless, I'll leave it up to you to decide whether or not it's worth applying.
Signed-off-by: Dave Jones <davej@redhat.com>
--- linux-2.6.14/drivers/serial/8250_pci.c~ 2005-12-07 11:56:13.000000000 -0500 +++ linux-2.6.14/drivers/serial/8250_pci.c 2005-12-07 11:56:41.000000000 -0500 @@ -516,7 +516,6 @@ pci_timedia_setup(struct serial_private break; case 3: offset = board->uart_offset; - bar = 1; case 4: /* BAR 2 */ case 5: /* BAR 3 */ case 6: /* BAR 4 */ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |