Messages in this thread | | | Date | Tue, 6 Dec 2005 11:40:41 -0800 | From | Greg KH <> | Subject | Re: [PATCH 00/10] usb-serial: Switches from spin lock to atomic_t. |
| |
On Tue, Dec 06, 2005 at 09:56:10AM -0200, Luiz Fernando Capitulino wrote: > Greg, > > Don't get scared. :-) > > As showed by Eduardo Habkost some days ago, the spin lock 'lock' in the > struct 'usb_serial_port' is being used by some USB serial drivers to protect > the access to the 'write_urb_busy' member of the same struct. > > The spin lock however, is needless: we can change 'write_urb_busy' type > to be atomic_t and remove all the spin lock usage.
But if you do that, you make things slower on non-smp machines, which isn't very nice. Why does the spinlock bother you?
thanks,
greg k-h - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
| |